Skip to content

bump(*) #22364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adambkaplan wants to merge 3 commits into from
Closed

bump(*) #22364

adambkaplan wants to merge 3 commits into from

Conversation

@adambkaplan
Copy link
Contributor

@adambkaplan adambkaplan commented Mar 19, 2019

Bumps to pull in api updates

  1. Rename Features to FeatureGate
  2. Pull in new Build status reason BuildPodEvicted

/assign @derekwaynecarr
/cc @deads2k

@adambkaplan
bump(*)
6654b11
@adambkaplan
renames
1fffc47 
* Features/FeatureGate/
* FeaturesSpec/FeatureGateSpec
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 19, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adambkaplan
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: derekwaynecarr

If they are not already assigned, you can assign the PR to them by writing /assign @derekwaynecarr in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 19, 2019
adambkaplan
adambkaplan commented Mar 19, 2019
View reviewed changes
glide.lock
- config/v1beta1
- name: k8s.io/kubernetes
version: de991a22fa8b3fb4d68abc87a064377cc793135a
version: c398de65fed4a7fbdc0b8a0c0682623d9dad41e1
Copy link
Contributor Author

@adambkaplan adambkaplan Mar 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deads2k were the kube bumps not supposed to happen? Seeing unit tests fail with panic.

@adambkaplan
Copy link
Contributor Author

adambkaplan commented Mar 21, 2019

/retest

@adambkaplan
Copy link
Contributor Author

adambkaplan commented Mar 21, 2019

@deads2k ping - are we holding off bumps now that 1.13 rebase is in-flight?

@adambkaplan
Copy link
Contributor Author

adambkaplan commented Mar 21, 2019

Closing in favor of #22389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@derekwaynecarr derekwaynecarr

Labels

size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adambkaplan @openshift-ci-robot @derekwaynecarr